Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing --volume-attach-limit to the csi driver #164

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Allow passing --volume-attach-limit to the csi driver #164

merged 1 commit into from
Aug 12, 2020

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Aug 11, 2020 •
edited
Loading

How to categorize this PR?

/area storage
/kind task
/priority normal
/platform aws

What this PR does / why we need it:
Allow passing --volume-attach-limit to the csi driver. Ref kubernetes-sigs/aws-ebs-csi-driver#522.

Which issue(s) this PR fixes:
Fixes #159

Special notes for your reviewer:
Depends on:

Release note:

`provider-aws` does now allow configuring the `--volume-attach-limit` flag of the AWS EBS CSI driver via `aws.provider.extensions.gardener.cloud/volume-attach-limit` annotation on Shoot.

@gardener-robot gardener-robot added area/storage Storage related kind/task General task platform/aws Amazon web services platform/infrastructure priority/normal labels Aug 11, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2020
@ialidzhikov ialidzhikov force-pushed the enh/volume-attach-limit branch from 6f22750 to 2ef8268 Compare August 11, 2020 19:40
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2020
rfranzke
rfranzke reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice PR.

/needs rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Aug 12, 2020
@hardikdr
Copy link
Member

Looks great, thanks for the PR :)

@ialidzhikov ialidzhikov force-pushed the enh/volume-attach-limit branch from 2ef8268 to f792946 Compare August 12, 2020 08:22
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2020
rfranzke
rfranzke reviewed Aug 12, 2020
View reviewed changes
docs/usage-as-end-user.md Outdated Show resolved Hide resolved
docs/usage-as-end-user.md Outdated Show resolved Hide resolved
docs/usage-as-end-user.md Outdated Show resolved Hide resolved
@ialidzhikov ialidzhikov force-pushed the enh/volume-attach-limit branch from f792946 to 2869cf1 Compare August 12, 2020 09:11
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2020
@ialidzhikov ialidzhikov marked this pull request as ready for review August 12, 2020 09:13
@ialidzhikov ialidzhikov requested a review from a team as a code owner August 12, 2020 09:13
rfranzke
rfranzke approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase labels Aug 12, 2020
@rfranzke rfranzke merged commit 6f55faa into gardener:master Aug 12, 2020
@ialidzhikov ialidzhikov deleted the enh/volume-attach-limit branch September 8, 2020 16:27
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/storage Storage related kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the EBS CSI driver configurable
7 participants
@ialidzhikov @hardikdr @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot